Skip to content

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented May 19, 2025

Items such as the declare_tool_lint!() macro are publicly reexported from rustc_lint_defs to rustc_session. Use the latter for consistency.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 19, 2025
@samueltardieu samueltardieu force-pushed the rustc-session-instead-of-rustc-lint-defs branch from 6051d9e to 7401966 Compare May 19, 2025 16:05
Items such as the `declare_tool_lint!()` macro are publicly reexported
from `rustc_lint_defs` to `rustc_session`. Use the latter for
consistency.
@samueltardieu samueltardieu force-pushed the rustc-session-instead-of-rustc-lint-defs branch from 7401966 to e2b1de1 Compare May 19, 2025 16:05
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only used rustc_lint_defs for declare_tool_lint? Cool to see it removed, although it will probably be re-added sometime in the future because that module contains really some useful modules.

@blyxyas blyxyas added this pull request to the merge queue May 19, 2025
Merged via the queue into rust-lang:master with commit d4e7e5b May 19, 2025
11 checks passed
@samueltardieu samueltardieu deleted the rustc-session-instead-of-rustc-lint-defs branch May 19, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants