Add suggestions to EXPLICIT_[INTO_]ITER_LOOP
#1486
Conversation
Also reduces the highlighted span to the expr containing the `.[into_]iter()` call (so the suggestion is probably applicable by rustfix.) Fixes rust-lang#1484
|
Didn't hear anything from you, @mcarton, so here is my PR :) Changing this code once again reminded me of how crazy deeply indented everything in clippy is. Or maybe I just need a wider screen? |
tests/compile-fail/for_loop.rs
Outdated
| for i in (10..0).map(|x| x * 2) { | ||
| println!("{}", i); | ||
| }*/ | ||
| } |
There was a problem hiding this comment.
Any reason this was commented out before? Seems fine to me
There was a problem hiding this comment.
Dunno. But 10..0 is an empty range so that's a bad example anyway.
There was a problem hiding this comment.
Oh, right. I'll just remove it, okay?
tests/compile-fail/for_loop.rs
Outdated
| for _v in vec.iter() { } | ||
| //~^ ERROR it is more idiomatic to loop over `&vec` | ||
| //~| HELP to write this more concisely, try looping over | ||
| //~| SUGGESTION &vec |
There was a problem hiding this comment.
I usually prefer to had a bit of context around the suggestion, just to be sure:
//~| SUGGESTION for _v in &vec {There was a problem hiding this comment.
Is compile-test clever enough to pick this up even if my suggestion only contains &vec? (Let's find out!)
|
Looks good 😄
I can display 91 columns on half a screen, but yeah, it might be hard to fit there :sad: |
|
Come on, the travis failure is |db| {⏎
- db.span_suggestion(arg.span,⏎
- "to write this more concisely, try looping over",⏎
- object.to_string());⏎
+ db.span_suggestion(arg.span, "to write this more concisely, try looping over", object.to_string());⏎
});⏎How is that better? |
|
Lol, I reinstalled rustfmt an hour ago. Literally! This is my prompt when I scroll up (notice the time on the right): But fine, I'll make you happy, Travis. |
|
Thanks! |
2 participants
Also reduces the highlighted span to the expr containing the
.[into_]iter()call (so the suggestion is probably applicable by rustfix.)Fixes #1484