Add MSRV test for unnecessary_debug_formatting with OsStr
#15001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
hey folks, can we get this merged? |
lopopolo
added a commit
to artichoke/intaglio
that referenced
this pull request
Jun 19, 2025
lopopolo
added a commit
to artichoke/intaglio
that referenced
this pull request
Jun 19, 2025
lopopolo
added a commit
to artichoke/intaglio
that referenced
this pull request
Jun 19, 2025
|
The lint was working correctly in the first place. Can you keep just the test on |
donkomura
force-pushed
the
fix-unnecessary-debug-formatting-msrv
branch
from
b2d176f to
424bdc9
Compare
|
Thank you for the information. I removed the test on |
|
The rest of the changes are also unnecessary. The lint was already correctly checking the required MSRV in |
|
☔ The latest upstream changes (possibly 6064822) made this pull request unmergeable. Please resolve the merge conflicts. |
`unnecessary_debug_formatting` suggests display() respected for MSRV but lacking of tests. This adds tests to check MSRV for OsStr. changelog: none
donkomura
force-pushed
the
fix-unnecessary-debug-formatting-msrv
branch
from
424bdc9 to
e0cb4ce
Compare
donkomura
changed the title
unnecessary_debug_formatting respect MSRVunnecessary_debug_formatting
|
updated |
samueltardieu
changed the title
unnecessary_debug_formattingunnecessary_debug_formatting with OsStr
samueltardieu
approved these changes
Jun 21, 2025
|
Merging as the change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unnecessary_debug_formattingsuggests display() respected forMSRV but lacking of tests. This adds tests to check MSRV for OsStr.
changelog: none