Skip to content

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Jun 14, 2025

followup of rust-lang/rust#141874

cc rust-lang/rust#116909

changelog: check f16 and f128 in float_equality_without_abs

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 14, 2025
@y21
Copy link
Member

y21 commented Jun 14, 2025

Can you also add tests for this? It seems like there's also a f16_f128 FIXME in the code that could easily be resolved in the same PR here:

// FIXME(f16_f128): add tests for these types when abs is available

@usamoi
Copy link
Contributor Author

usamoi commented Jun 14, 2025

Can you also add tests for this?

Added.

Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the needless query overhead this looks good. Please fix this small nit. And sorry for the delay.

@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@llogiq
Copy link
Contributor

llogiq commented Aug 24, 2025

Thank you!

@llogiq llogiq added this pull request to the merge queue Aug 24, 2025
Merged via the queue into rust-lang:master with commit ad419b8 Aug 24, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants