[[infinite_loop] fix infinite loop false positive #15157
Merged
+137
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odysa
force-pushed
the
fix/inf-loop-err
branch
4 times, most recently
from
c6af9da to
5e3812b
Compare
odysa
changed the title
rustbot
added
the
S-waiting-on-review
dswij
approved these changes
Aug 6, 2025
samueltardieu
requested changes
Aug 6, 2025
|
LOL. It always gets me that comments are invisible until you finish the review. |
samueltardieu
approved these changes
Aug 8, 2025
|
Thanks @odysa @samueltardieu |
rustbot
removed
the
S-waiting-on-review
teor2345
reviewed
Aug 17, 2025
| } | ||
|
|
||
| fn await_async_block() { | ||
| // This SHOULD trigger the lint because the async block is awaited |
There was a problem hiding this comment.
I think this was meant to be:
This should NOT trigger the lint because the async block is not awaited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [infinite_loop]: Improve handling of infinite loops in async blocks
Fix #14000
This PR refines the [infinite_loop] lint to avoid false positives when infinite loops occur inside async blocks that are not awaited (such as those that are spawned or assigned to variables for later use). The lint will now only trigger when the async block containing the loop is directly awaited.