rustup and compile-fail -> ui test move #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to bed. Feel free to take over. |
mcarton
reviewed
Feb 7, 2017
CONTRIBUTING.md
Outdated
| Clippy uses UI tests. UI tests check that the output of the compiler is exactly as expected. | ||
| Of course there's little sense in writing the output yourself or copying it around. | ||
| Therefore you can simply run `tests/ui/update-all-references.sh` and check whether | ||
| the output looks as you expect with `git diff`. Commit all `.stderr` files, too. |
There was a problem hiding this comment.
👍 Nice of you to update that!
I'd just say “Commit all *.stderr files” because I though for a moment “why the hell those are hidden files?”.
They are moving to just checking true compilation failures that abort the program. Everything else is a ui test. |
|
r+ modulo |
|
“remove all //~ from tests” → the end of an era 😢 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1519