Skip to content

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jul 16, 2025

This makes const contexts use the const-stability version information instead of the regular stability one, as const-stability may happen much later than stability in non-const contexts.

It includes the content of PR #15296 as its first commit. I separated them because this one is more complex, and #15296 may be merged more rapidly.

changelog: [incompatible_msrv]: check the right MSRV when in a const context

r? Jarcho @rustbot label +C-bug +I-false-negative

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't labels Jul 16, 2025
Copy link

github-actions bot commented Jul 16, 2025

Lintcheck changes for 167ac05

Lint Added Removed Changed
clippy::incompatible_msrv 2 0 1

This comment will be updated if you push new changes

@samueltardieu
Copy link
Member Author

@rustbot note Blocked by #15296
@rustbot blocked

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 16, 2025
@samueltardieu samueltardieu force-pushed the incompatible-msrv-const branch from b259bb8 to 04ed08b Compare July 17, 2025 07:47
@samueltardieu
Copy link
Member Author

@rustbot note remove Blocked by #15296
@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Jul 17, 2025
This makes `const` contexts use the `const`-stability version information
instead of the regular stability one, as `const`-stability may happen
much later than stability in non-`const` contexts.
@samueltardieu samueltardieu force-pushed the incompatible-msrv-const branch from 04ed08b to 167ac05 Compare July 17, 2025 12:45
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Jul 18, 2025
Merged via the queue into rust-lang:master with commit ae8ff77 Jul 18, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 18, 2025
@samueltardieu samueltardieu deleted the incompatible-msrv-const branch July 18, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants