Optimize needless_bool lint
#15423
Merged
Optimize needless_bool lint
#15423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueltardieu
added
the
G-performance-project
rustbot
added
the
S-waiting-on-review
|
Performance improvements have not been measured experimentally, this is only a reaction to #clippy > Clippy's performance "monthly" update @ 💬. |
blyxyas
requested changes
Aug 6, 2025
clippy_lints/src/needless_bool.rs
Outdated
| && let Some(higher::If { | ||
| cond, | ||
| then, | ||
| r#else: Some(r#else), |
There was a problem hiding this comment.
I think it would be more ergonomic to get rid of this r#else block and just call it else_block. I'm not sure why we have so many r#.. identifiers when they're so awkward to use.
Suggested change
| r#else: Some(r#else), | |
| r#else: Some(else_block), |
There was a problem hiding this comment.
Renamed into else_expr, since it might not be a block (only the then is guaranteed to be one).
rustbot
added
S-waiting-on-author
Two optimizations have been done when checking for the context in which to apply the lint: - Checking for the mere presence of comments does not require building a `String` with the comment to then check if it is empty and discard it. - Checking for the presence of comment can be done after we have checked that we do have a `if` construct that we intend to lint instead of for every expression.
samueltardieu
force-pushed
the
optimize-needless-bool
branch
from
87a2a7a to
8602faa
Compare
rustbot
added
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two optimizations have been done when checking for the context in which to apply the lint:
Stringwith the comment to then check if it is empty and discard it.ifconstruct that we intend to lint instead of for every expression.changelog: none
r? blyxyas