Skip to content

Reuse previous Vec allocation in loop #15428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Reuse previous Vec allocation in loop #15428

merged 1 commit into from
Aug 7, 2025

Conversation

samueltardieu
Copy link
Member

Minor optimization to avoid deallocating/reallocating a new Vec in the top check_doc loop.

changelog: none

r? blyxyas

@samueltardieu samueltardieu added the G-performance-project Goal: For issues and PRs related to the Clippy Performance Project label Aug 7, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 7, 2025

Some changes occurred in clippy_lints/src/doc

cc @notriddle

blyxyas
blyxyas approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going from 18,060,503 icount to 17,953,881 on the Documentation pass! That's a 0.5% improvement! Thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Aug 7, 2025
Merged via the queue into rust-lang:master with commit 32a216e Aug 7, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 7, 2025
@samueltardieu samueltardieu deleted the optimize-doc-vec-realloc branch August 9, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
G-performance-project Goal: For issues and PRs related to the Clippy Performance Project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samueltardieu @rustbot @blyxyas