-
Notifications
You must be signed in to change notification settings - Fork 1.8k
{borrow,ptr}_as_ptr
: don't lint inside proc-macros
#15473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
we return `false` outside of the `if` anyway
dd2d448
to
0470d0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit is not correct. is_from_proc_macro
is actually broken and doesn't account for macro variables at all. I would just revert that change and leave a FIXME
note in it's place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Can you just squash the last three commits down please.
notice that this stops `inline!` from working as well
03a39ec
to
9570ed8
Compare
done! |
{borrow,ptr}_as_ptr
{borrow,ptr}_as_ptr
: don't lint inside proc-macros
this could arguably be 2 separate PRs, but both of these were brought up in the same issue, so..
fixes #15398
changelog: [
borrow_as_ptr
]: don't lint inside proc-macroschangelog: [
ptr_as_ptr
]: don't lint inside proc-macros