-
Notifications
You must be signed in to change notification settings - Fork 1.8k
extract bool_comparison
to a separate file
#15499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samueltardieu
merged 1 commit into
rust-lang:master
from
ada4a:bool-comparison-extract-file
Aug 23, 2025
Merged
extract bool_comparison
to a separate file
#15499
samueltardieu
merged 1 commit into
rust-lang:master
from
ada4a:bool-comparison-extract-file
Aug 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes for f0563ad |
I'm not^^ let's see if this will work.. @rustbot label S-waiting-on-review -A-lint -S-blocked |
@rustbot note remove Feature-freeze |
a4b9011
to
58a850a
Compare
samueltardieu
requested changes
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
58a850a
to
f0563ad
Compare
samueltardieu
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-blocked
Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I don't really understand, this lint was mushed together with
needless_bool(_assign)
, even though they seemingly didn't have a lot of overlapping logic -- for one, their lint passes are separate, and can't be merged in a meaningful way.I first wanted to move the file under
booleans/
and move the common logic intoutils.rs
, and then split the files, but it turns out that the entirety of common logic was thefetch_bool_expr
function, which is literally justexpr.as_literal()?.as_bool()
. So I scratched that idea, movedbool_comparison
logic to a new file, and copy-pasted the function into it.I think this change is advantageous in two main ways:
clippy::bool_comparison
becomes easier to find, because now there's a file with that name.This PR depends on #15498, but only for easier-rebase purposes.
changelog: none