Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 9, 2025

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just the most minor of nits

View changes since this review

const DATA: Data = Data([1, 2, 3, 4]);
const CONST_I32: i32 = 1;

// issue #13012
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nitty nit, could this be a Github link so that people can click it from their editors instead of manually searching for it?

@ada4a
Copy link
Contributor Author

ada4a commented Sep 14, 2025

@rustbot ready

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!! ❤️

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Sep 19, 2025
Merged via the queue into rust-lang:master with commit 1c14af8 Sep 19, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 19, 2025
@ada4a ada4a deleted the single_match branch September 19, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants