Skip to content

Accessing Span internals is deprecated #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2017
Merged

Accessing Span internals is deprecated #2006

merged 2 commits into from
Aug 31, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Aug 31, 2017

No description provided.

petrochenkov
petrochenkov reviewed Aug 31, 2017
View reviewed changes
clippy_lints/src/if_let_redundant_pattern_matching.rs Outdated
expr.span.lo(),
op.span.hi(),
expr.span.ctxt(),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this is expr.span.with_hi(op.span.hi())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oli-obk oli-obk merged commit 3fe6454 into master Aug 31, 2017
@oli-obk oli-obk deleted the rustup branch August 31, 2017 13:38
@mcarton mcarton mentioned this pull request Aug 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oli-obk @petrochenkov