-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Suggest print #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest print #2131
Conversation
clippy_lints/src/suggest_print.rs
Outdated
declare_lint! { | ||
pub SUGGEST_PRINT, | ||
Warn, | ||
"using `write!()` family of functions instead of `print!()` family of \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the write!()
family" "the print!()
family"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also done.
clippy_lints/src/suggest_print.rs
Outdated
/// writeln!(&mut io::stderr(), "foo: {:?}", bar).unwrap(); | ||
/// ``` | ||
declare_lint! { | ||
pub SUGGEST_PRINT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call it EXPLICIT_WRITE instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I agree, that is a much better name.
From `suggest_print` to `explicit_write`
suggest_print.rs -> explicit_write.rs
Thanks! |
Fix #2083