Lint passing Cow by reference #2493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lint for reference to Cow to the same place in the code where lint for reference to String lives. rust-lang#2405
|
actually the same tests failed without this commit so the current test failures are unrelated |
bootandy
commented
Feb 28, 2018
clippy_lints/src/ptr.rs
Outdated
| @@ -213,6 +213,21 @@ fn check_fn(cx: &LateContext, decl: &FnDecl, fn_id: NodeId, opt_body_id: Option< | |||
| }, | |||
| ); | |||
| } | |||
| } else if match_type(cx, ty, &paths::COW) { | |||
| let as_str = format!("{}", snippet_opt(cx, arg.span).unwrap()); | |||
There was a problem hiding this comment.
Is it ok to call unwrap() like this? I could import the function snippet() instead as that doesn't return a Result object
There was a problem hiding this comment.
I'll review more next week, but clippy dogfood will disallow the unwrap and the trivial format.
If there is no snippet, we should not be producing a suggestion.
There was a problem hiding this comment.
Interestingly the dogfood test passed for me locally with this code.
I will update this code as you suggested, thanks.
|
I'd recommend changing |
Add `rustc --explain E0308` line to relevant tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lint for reference to Cow to the same place in the code where
the lint for detecting a reference to String lives.
Fixes #2405