Skip to content

Don't trigger while_immutable_condition for mutable fields #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2018
Merged

Don't trigger while_immutable_condition for mutable fields #2622

merged 1 commit into from
Apr 3, 2018

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 3, 2018

Fixes #2609

oli-obk
oli-obk reviewed Apr 3, 2018
View reviewed changes
clippy_lints/src/loops.rs
@@ -2237,7 +2237,7 @@ struct MutVarsDelegate {
}

impl<'tcx> MutVarsDelegate {
fn update(&mut self, cat: &'tcx Categorization, sp: Span) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a lint for this. Passing args to a function which are only ever used to recusively call itself

@oli-obk oli-obk merged commit a3cdcf1 into rust-lang:master Apr 3, 2018
@flip1995 flip1995 deleted the imm_while_fields branch April 3, 2018 22:31
@flip1995 flip1995 mentioned this pull request Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flip1995 @oli-obk