unreadable_literal: Fills hexadecimal values with 0 to allow better grouping #2813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terry90
changed the title
|
Thanks for the contribution and welcome to clippy! This lgtm, but since I'm new to this reviewing thing: @oli-obk ? 😄 |
oli-obk
suggested changes
Jun 2, 2018
| .collect::<Vec<String>>() | ||
| .join("_"); | ||
| // Forces hexadecimal values to be grouped by 4 being filled with zeroes (e.g 0x00ab_cdef) | ||
| let nb_digits_to_fill = self.digits.chars().filter(|&c| c != '_').collect::<Vec<_>>().len() % 4; |
There was a problem hiding this comment.
Since this is almost doing the same thing as what's happening above, can you store the intermediate Vec from above in a variable and reuse it here? The reversion above is irrelevant for counting.
|
@oli-obk done ! 👍 |
oli-obk
approved these changes
Jun 3, 2018
|
great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2300