Setup bors for Clippy #3348
Setup bors for Clippy #3348
Conversation
flip1995
added
the
S-needs-discussion
| @@ -9,6 +9,15 @@ os: | |||
|
|
|||
| sudo: false | |||
|
|
|||
| branches: | |||
| only: | |||
There was a problem hiding this comment.
This will prevent that PRs created from a branch within this repo will get checked twice by appveyor and travis. (For example #2783)
| # This is where pull requests from "bors try" are built. | ||
| - trying | ||
| # Also build pull requests. | ||
| - master |
There was a problem hiding this comment.
As long as this is activated PRs will still get checked by appveyor and travis (once).
|
I set up bors on some of my own repos this weekend and this LGTM. If I understand the docs correctly:
then this will trigger a build already if it creates the bors try edit: Seems like GitHub is still having issues |
|
I also setup bors for a university project yesterday. And I like it!
Yeah ci hasn't started either. I think/hope this is related to the github issues and not the Oh and I also need to add the |
|
bors try (GitHub is still working through a backlog of webhook deliveries, but might as well give it another |
|
It already triggered 18bf72c But I think travis and appveyor are a little bit overloaded as well atm. |
tryTimed out |
|
Will we force all merges to go through bors? If something breaks ci (like the appveyor dogfood test recently) will it mean that no PRs will be merged until that is fixed (even it is unrelated to the PRs wanting to be merged)? But of course it might lead to such breakages be addressed much faster in the future on the other hand.. |
|
Generally I would say yes, every PR should get merged through bors (it's also easier for the reviewers). On special occasions, such as unrelated build failures, where the fix might take a few days/weeks, merging by hand is an option, while an infra fix is still preferred.
That would be a nice side effect! |
|
Well the timeout mechanism works #3348 (comment) 😄 |
This comment has been minimized.
This comment has been minimized.
tryTimed out |
|
bors try |
tryBuild succeeded |
|
cool 👍 |
|
We can always add the required checks later on. That's not part of the PR anyway, I guess. @Manishearth @oli-obk Is there anything else that would speak against merging this? |
Nope. You wanna do the honors? |
|
🎉 bors r+ |
|
bors ping |
|
pong |
|
bors r+ (looks like I had to create the |
3348: Setup bors for Clippy r=phansch a=flip1995 Since [bors-ng](https://app.bors.tech/repositories/3993) is already installed for this repo for a while (#3279 (comment)), the only thing missing, before we can use it, is the `bors.toml`. (bors-ng [docs](https://bors.tech/documentation/getting-started/)) If we want to move forward with this and this gets merged, the only thing left to do is to create the branches `staging` and `trying`. @phansch @oli-obk Co-authored-by: flip1995 <[email protected]> Co-authored-by: Philipp Krones <[email protected]>
Since bors-ng is already installed for this repo for a while (#3279 (comment)), the only thing missing, before we can use it, is the
bors.toml. (bors-ng docs)If we want to move forward with this and this gets merged, the only thing left to do is to create the branches
stagingandtrying.@phansch @oli-obk