WiP: Fix wrong_self_convention false positive (#3414) #3562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #3767) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ping @tormol. I'm going over old PRs, that were abandoned by us reviewers (sorry for that!) or by the authors. Are you still interested in completing this? |
|
Not really. |
flip1995
added
S-inactive-closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current fix passes tests but is likely too broad:
It is not limited to types with generic
Derefimpls, and modifiesSelfKind.matches()which is also used for the should_implement_trait lint.I am a bit stuck on detecting generic Deref impls: I started copying
has_debug_impl()before realizing that function takesty::Tyinstead ofhir::Ty. I also haven't figured out how to get or check the associated type of a trait impl.The issue only mentions
into_*wanting self by value, but could there be similar false positives with phrases for which the lint wants&selfor&mut self?Related: It doesn't look like there's a lint against inherent methods with
selfon types that deref to an unknown (generic) type. Should I add one?