Fix cast_sign_loss false positive
#3725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks if the value is a non-negative constant before linting about losing the sign. Because the `constant` function doesn't handle const functions, we check if the value is from a call to a `max_value` function directly. A utility method called `get_def_path` was added to make checking for the function paths easier. Fixes #2728
phansch
added
the
S-waiting-on-review
oli-obk
reviewed
Jan 31, 2019
|
I made the suggested changes. |
phansch
approved these changes
Feb 2, 2019
|
@bors r+ thanks! |
|
📌 Commit f3ee53d has been approved by |
bors
added a commit
that referenced
this pull request
Feb 4, 2019
Fix `cast_sign_loss` false positive This checks if the value is a non-negative constant before linting about losing the sign. Because the `constant` function doesn't handle const functions, we check if the value is from a call to a `max_value` function directly. A utility method called `get_def_path` was added to make checking for the function paths easier. Fixes #2728
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks if the value is a non-negative constant before linting about
losing the sign.
Because the
constantfunction doesn't handle const functions, we check ifthe value is from a call to a
max_valuefunction directly. A utility methodcalled
get_def_pathwas added to make checking for the function pathseasier.
Fixes #2728