Extend the use_self lint to suggest uses of Self::Variant
#4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Jul 31, 2019
flip1995
requested changes
Jul 31, 2019
One struct required a temporary `#[allow(dead_code)]` annotation due to a bug in the Rust compiler: rust-lang/rust#63151.
flip1995
added
the
S-waiting-on-review
flip1995
approved these changes
Jul 31, 2019
|
Thanks! @bors r+ |
|
📌 Commit 2a13e83 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 31, 2019
Extend the `use_self` lint to suggest uses of `Self::Variant` Fixes #4296. changelog: Extend the `use_self` lint to suggest uses of `Self::Variant`
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4296.
changelog: Extend the
use_selflint to suggest uses ofSelf::Variant