Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clippy_lints/src/utils/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ pub fn in_constant(cx: &LateContext<'_, '_>, id: HirId) -> bool {
node: ItemKind::Fn(_, header, ..),
..
}) => header.constness == Constness::Const,
Node::ImplItem(&ImplItem {
node: ImplItemKind::Method(ref sig, _),
..
}) => sig.header.constness == Constness::Const,
_ => false,
}
}
Expand Down
11 changes: 11 additions & 0 deletions tests/ui/cast_lossless_float.fixed
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,14 @@ fn main() {
const fn abc(input: f32) -> f64 {
input as f64
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: f32) -> f64 {
x as f64
}
}
}
11 changes: 11 additions & 0 deletions tests/ui/cast_lossless_float.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,14 @@ fn main() {
const fn abc(input: f32) -> f64 {
input as f64
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: f32) -> f64 {
x as f64
}
}
}
11 changes: 11 additions & 0 deletions tests/ui/cast_lossless_integer.fixed
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,14 @@ fn main() {
const fn abc(input: u16) -> u32 {
input as u32
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: u32) -> u64 {
x as u64
}
}
}
11 changes: 11 additions & 0 deletions tests/ui/cast_lossless_integer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,14 @@ fn main() {
const fn abc(input: u16) -> u32 {
input as u32
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: u32) -> u64 {
x as u64
}
}
}