Skip to content

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Sep 29, 2019

changelog: Improve suggestion of zero_ptr lint

@tesuji tesuji force-pushed the zero-ptr-suggestion branch from d5d52cf to b37f971 Compare September 29, 2019 16:49
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 29, 2019
@tesuji tesuji force-pushed the zero-ptr-suggestion branch 3 times, most recently from 3ddd825 to e903b8f Compare October 2, 2019 14:24
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good already, I think this should be good with only one change!

@tesuji tesuji force-pushed the zero-ptr-suggestion branch from a1c24bf to b325973 Compare October 2, 2019 14:58
@tesuji tesuji force-pushed the zero-ptr-suggestion branch from 883c3a0 to 6b1a868 Compare October 2, 2019 15:38
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Waiting for travis.

@flip1995
Copy link
Member

flip1995 commented Oct 2, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 2, 2019

📌 Commit 6b1a868 has been approved by flip1995

bors added a commit that referenced this pull request Oct 2, 2019
Add suggestion for zero-ptr lint

changelog: Improve suggestion of `zero_ptr` lint
@bors
Copy link
Contributor

bors commented Oct 2, 2019

⌛ Testing commit 6b1a868 with merge 737f0a6...

@bors
Copy link
Contributor

bors commented Oct 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 737f0a6 to master...

@bors bors merged commit 6b1a868 into rust-lang:master Oct 2, 2019
@tesuji tesuji deleted the zero-ptr-suggestion branch October 2, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants