Skip to content

Few improvement to utils::conf module #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

Few improvement to utils::conf module #5135

merged 1 commit into from
Feb 5, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Feb 4, 2020

  • Fix a few typos
  • Handle Option<&Path> early
  • Use env::var_os when possible

changelog: none

@tesuji tesuji requested a review from flip1995 February 4, 2020 15:38
@tesuji

This comment has been minimized.

Sign in to view
flip1995
flip1995 approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Feb 4, 2020
@tesuji
Few improvement to utils::conf module
32924c6 
* Fix a few typos
* Handle Option<&Path> early
* Use `env::var_os` when possible
@tesuji
Copy link
Contributor Author

tesuji commented Feb 5, 2020

Done

@tesuji
Copy link
Contributor Author

tesuji commented Feb 5, 2020 •
edited
Loading

It's interesting with #4950, in fn read I locked the ERRORS in start of the function
, it made the ui-toml/bad_toml_types test hang.

@flip1995
Copy link
Member

flip1995 commented Feb 5, 2020

I guess, this is because tests are run in parallel?

@bors r+

@bors
Copy link
Contributor

bors commented Feb 5, 2020

📌 Commit 32924c6 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 5, 2020

⌛ Testing commit 32924c6 with merge c881aca...

bors added a commit that referenced this pull request Feb 5, 2020
@bors
Auto merge of #5135 - lzutao:config, r=flip1995
c881aca 
Few improvement to `utils::conf` module

* Fix a few typos
* Handle Option<&Path> early
* Use `env::var_os` when possible

changelog: none
@bors
Copy link
Contributor

bors commented Feb 5, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing c881aca to master...

@bors bors merged commit 32924c6 into rust-lang:master Feb 5, 2020
@tesuji tesuji deleted the config branch February 5, 2020 10:58
@flip1995 flip1995 mentioned this pull request Mar 22, 2020
Merged
bors added a commit that referenced this pull request Mar 22, 2020
@bors
Auto merge of #5353 - flip1995:conf_doc, r=Manishearth
89303da 
Fix documentation generation for configurable lints

In #5135, the configuration macro changed, but the documentation generation script wasn't updated. This PR catches up on this.

[Preview](https://flip1995.github.io/rust-clippy/master/index.html)

r? @Manishearth

changelog: Document configuration options of lints again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesuji @flip1995 @bors