Minor edit to text region replacement #5140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Feb 6, 2020
tesuji
force-pushed
the
cleanup-replace
branch
2 times, most recently
from
702f258 to
dda13d4
Compare
tesuji
force-pushed
the
cleanup-replace
branch
from
dda13d4 to
cf58537
Compare
sinkuu
reviewed
Feb 7, 2020
| } | ||
|
|
||
| pub static DOCS_LINK: &str = "https://rust-lang.github.io/rust-clippy/master/index.html"; |
There was a problem hiding this comment.
I had an debate with people on rustup. It seems that people prefer static str rather than
const str. They like that because static item have static address in binary.
|
@bors r+ |
|
📌 Commit cf58537 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 7, 2020
Minor edit to text region replacement changelog: none
|
💔 Test failed - status-appveyor |
flip1995
added
the
S-waiting-on-bors
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 7, 2020
Minor edit to text region replacement changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none