[DNM] Also install llvm-tools on toolchain setup #5630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-blocked
Try removing |
|
This looks correct to me. |
|
Yes there are linking errors. https://github.com/rust-lang/rust-clippy/pull/5632/checks?check_run_id=699500949 But it's This is included in #5632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for rust-lang/rust#72000
cc @cuviper @Mark-Simulacrum Is this the correct way to install the llvm-tools with RTIM?
Before merging this, I want to try if llvm-tools are really necessary to compile Clippy. From the rust PR I understood, that it probably will be.
changelog: none