new lint: unknown features #5643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, I just learnt from #5518 that pre-expansion lints are going to be deprecated in rustc, so maybe merging this is not the best idea 😢 I'm not sure if there is a way to catch active attributes after they are removed during expansion, so this lint may not be possible anymore. |
bors
added a commit
that referenced
this pull request
May 31, 2020
cargo-ui tests: check that <dir>/src exists before processing test I forgot that I had fixed this in a PR I closed some days ago (#5643). Before this change, cargo UI tests could fail when switching between branches if the previous branch had a test that the current branch does not have. The directory is not removed when switching because an ignored `Cargo.lock` file exists, and the code was trying to reach `$DIR/src` unconditionally. This change will just skip a directory that has no `src` subdirectory. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: added new lint
unknown featuresthat checks for references to features not defined in the cargo manifest file.Closes #1614