Skip to content

Conversation

flip1995
Copy link
Member

Backport #5961

changelog: none

@rust-highfive
Copy link

r? @matthiaskrgr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 28, 2020
@flip1995 flip1995 changed the title [beta] Backport: Re-enable len_zero for ranges now that is_empty is stable on them WIP: [beta] Backport: Re-enable len_zero for ranges now that is_empty is stable on them Aug 28, 2020
@flip1995
Copy link
Member Author

This will not pass CI. We currently don't have set up CI for beta backports. With git subtree and similar problems like mentioned in #5981 this may be hard to setup.

I tested this locally, but will also test if it passes the rustc test suite locally, before this can be merged.

@flip1995 flip1995 changed the title WIP: [beta] Backport: Re-enable len_zero for ranges now that is_empty is stable on them [beta] Backport: Re-enable len_zero for ranges now that is_empty is stable on them Aug 29, 2020
@flip1995
Copy link
Member Author

Alright, it passed the rustc test suite locally.

@flip1995 flip1995 merged commit 12b8c64 into rust-lang:beta Aug 29, 2020
@flip1995 flip1995 deleted the backport branch August 29, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants