Fix FP in print_stdout

[giraffate]

Fix #6041

This lint shouldn't be emitted in build.rs as println! and print! are used for the build script.

changelog: none

[rust-highfive]

r? @yaahc

(rust_highfive has picked a reviewer for you, use r? to override)

[ebroto]

I left some comments regarding the detection of build scripts

[ebroto]

r? @ebroto

[giraffate]

@ebroto Thanks for your review! I addressed these.

[ebroto]

Besides the nits, two things:

• tests/ui/print_stdout_build_script.stderr can be removed, sorry I did not see that in my first review.
• I was thinking that we should add an integration test also to make sure the lint actually ignores real build scripts. Could you please add a build.rs file under clippy_workspace_tests similar to the print_stdout_build_script.rs that you added (also referencing the issue)? This will be tested by the dogfood tests.

[giraffate]

I was thinking that we should add an integration test also to make sure the lint actually ignores real build scripts. Could you please add a build.rs file under clippy_workspace_tests similar to the print_stdout_build_script.rs that you added (also referencing the issue)? This will be tested by the dogfood tests.

Thanks for your review. It's a good suggestion. However, I tried it but the build script under clippy_workspace_tests didn't work in the dogfood tests for some reason.

[ebroto]

I think the only missing thing was the deny attribute. I'll merge this if the tests pass.

Thanks for making Clippy better!

[ebroto]

@bors r+

[bors]

📌 Commit 1214a85 has been approved by ebroto

[bors]

⌛ Testing commit 1214a85 with merge b64d21d...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing b64d21d to master...