Refactor types #6938
Merged
Refactor types #6938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #6971) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks for all the great work on those refactors! @bors r+ p=3 |
|
I checked the const/static change with the lint check tool and it didn't trigger on any of the tested crates, so this change is definitely a positive change 👍 |
|
@bors are you still there? |
|
📌 Commit 818f832 has been approved by |
|
🍰 Activated
|
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @flip1995
This is the last PR to close #6724 🎉
Also, this fixes #6936.
changelog:
vec_box: Fix FN inconstorstaticchangelog:
linkedlist: Fix FN inconstorstaticchangelog:
option_option: Fix FN inconstorstatic