Skip to content

Fix bad suggestion for match_single_binding lint #6941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2021

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Mar 20, 2021

Fix a bad suggestion that needs curly braces when the target match is the body of an arm.

Fixes #6572

changelog: none

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 20, 2021
@llogiq
Copy link
Contributor

llogiq commented Mar 20, 2021

You are on a roll! Thanks once more. @bors r+

@bors
Copy link
Contributor

bors commented Mar 20, 2021

📌 Commit 7d45d8a has been approved by llogiq

@bors
Copy link
Contributor

bors commented Mar 20, 2021

⌛ Testing commit 7d45d8a with merge 0bdaa77...

@bors
Copy link
Contributor

bors commented Mar 20, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 0bdaa77 to master...

@bors bors merged commit 0bdaa77 into rust-lang:master Mar 20, 2021
@ThibsG ThibsG deleted the suggMatchSingleBinding branch March 20, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match_single_binding: match within a match suggests broken code
4 participants