Skip to content

needless_borrow: try to make lint example a bit more illustrating #7528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

matthiaskrgr
Copy link
Member

changelog: none

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 3, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2021

📌 Commit 54c41c0 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Aug 3, 2021

⌛ Testing commit 54c41c0 with merge 360ca77...

bors added a commit that referenced this pull request Aug 3, 2021
needless_borrow: try to make lint example a bit more illustrating

changelog: none
@bors
Copy link
Contributor

bors commented Aug 3, 2021

💔 Test failed - checks-action_remark_test

@giraffate
Copy link
Contributor

From error log in tests:

Run actions/[email protected]
/opt/hostedtoolcache/node/10.24.1/x64/bin/node --version
v10.24.1
/opt/hostedtoolcache/node/10.24.1/x64/bin/npm --version
6.14.12
/home/runner/work/rust-clippy/rust-clippy/node_modules/remark-cli/cli.js:2
import {createRequire} from 'node:module'
       ^

SyntaxError: Unexpected token {
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)

Node version might be old.

@giraffate giraffate mentioned this pull request Aug 4, 2021
bors added a commit that referenced this pull request Aug 4, 2021
Use node v12.x in CI

In #7528 (comment), remark-cli version has been updated recently and it requires to use ESM module: https://github.com/remarkjs/remark/releases/tag/14.0.0. Node version in CI was v10.24.1, it seems to be old.

changelog: none
bors added a commit that referenced this pull request Aug 4, 2021
Use node v12.x in CI

In #7528 (comment), remark-cli version has been updated recently and it requires to use ESM module: https://github.com/remarkjs/remark/releases/tag/14.0.0. Node version in CI was v10.24.1, it seems to be old.

changelog: none
@flip1995
Copy link
Member

flip1995 commented Aug 4, 2021

@bors retry

@bors
Copy link
Contributor

bors commented Aug 4, 2021

⌛ Testing commit 54c41c0 with merge 2dbf0c1...

@bors
Copy link
Contributor

bors commented Aug 4, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 2dbf0c1 to master...

@bors bors merged commit 2dbf0c1 into rust-lang:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants