Target directory cleanup #7646
Merged
Target directory cleanup #7646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
camsteffen
force-pushed
the
relative-target
branch
from
b61ab4d to
9e08e7f
Compare
|
Tested this in rustc and it seems that everything still works. Changes LGTM and this simplifies things. So: @bors r+ Thanks! |
|
📌 Commit 9e08e7f has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
matthiaskrgr
added a commit
to matthiaskrgr/clippy-lintcheck
that referenced
this pull request
Sep 14, 2021
path to clippy lintcheck binary changed in rust-lang/rust-clippy#7646
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 9, 2021
…mulacrum Remove unused clippy bootstrap env vars Continues rust-lang/rust-clippy#7646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none
target-dirspecified so that it is inherited by child projects. The target directory needs to be shared with clippy_dev, but not necessarily at the project root. (cc Set cargo's output directory to<repo root>/target/#7625)std::env::current_exe(and its parent directories) whenever possibleCLIPPY_DRIVER_PATHandTARGET_LIBSare no longer required from rustc bootstrap (butHOST_LIBSstill is). These can be removed from the rustc side after merging.CLIPPY_DOGFOODand the separate target directory are removed. This was originally added to mitigate Tests fail with conflicting external dependencies in the target directory #7343.r? @flip1995