Some test code cleanup #8266
Some test code cleanup #8266
Conversation
I believe this is possible as of rust-lang#7631
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
The two dogfood tests cannot be run concurrently since they use the same target directory.
This was more valuable when we used the latest nightly without specifying the toolchain version.
camsteffen
force-pushed
the
test-tweaks
branch
from
229d2f8 to
21343ab
Compare
This comment has been minimized.
This comment has been minimized.
Some test code cleanup changelog: none Mainly moves /clippy_workspace_tests into /tests and combines the two dogfood tests which can't run concurrently.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Some test code cleanup changelog: none Mainly moves /clippy_workspace_tests into /tests and combines the two dogfood tests which can't run concurrently.
This comment has been minimized.
This comment has been minimized.
camsteffen
force-pushed
the
test-tweaks
branch
from
490e786 to
01ef7c7
Compare
|
@bors try |
Some test code cleanup changelog: none Mainly moves /clippy_workspace_tests into /tests and combines the two dogfood tests which can't run concurrently.
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
| @@ -3,179 +3,26 @@ | |||
| //! | |||
| //! See [Eating your own dog food](https://en.wikipedia.org/wiki/Eating_your_own_dog_food) for context | |||
|
|
|||
| // Dogfood cannot run on Windows | |||
| #![cfg(not(windows))] | |||
There was a problem hiding this comment.
The windows and mac runners are our slowest runners in CI and also the current bottleneck. This added another 1-2min to the windows runner. So I wonder if we should only run those tests on unix. An argument against that is, that contributors using windows/mac, won't see dogfood errors until they submit a PR.
There was a problem hiding this comment.
Thanks for reviewing this.
Maybe I can find a way to get the best of both worlds using a flag or environment variable.
|
@bors try |
Some test code cleanup changelog: none Mainly moves /clippy_workspace_tests into /tests and combines the two dogfood tests which can't run concurrently.
camsteffen
force-pushed
the
test-tweaks
branch
from
49960fb to
90bf72c
Compare
|
@bors r=flip1995 |
|
📌 Commit 90bf72c has been approved by |
|
That's a neat solution! Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: none
Mainly moves /clippy_workspace_tests into /tests and combines the two dogfood tests which can't run concurrently.