Skip to content

Allow single_component_path_imports for all macros #8537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xFrednet
Copy link
Member

Closes: #7923

It can be useful to have use macro_name regardless of the visibility. This removes the visibility filter.

changelog: [single_component_path_imports]: no longer triggers on macros

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 14, 2022
@BartMassey
Copy link

Dang you are quick. Thanks much!

@llogiq
Copy link
Contributor

llogiq commented Mar 14, 2022

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2022

📌 Commit 2ee5372 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Mar 14, 2022

⌛ Testing commit 2ee5372 with merge 9a1f6a9...

@bors
Copy link
Contributor

bors commented Mar 14, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 9a1f6a9 to master...

@bors bors merged commit 9a1f6a9 into rust-lang:master Mar 14, 2022
@xFrednet xFrednet deleted the 7923-single-component-path-imports-for-macros branch March 15, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single_component_path_imports false positive for macros used in the same module
5 participants