Skip to content

update unnecessary_join documentation #8644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2022
Merged

update unnecessary_join documentation #8644

merged 1 commit into from
Apr 6, 2022

Conversation

yoav-lavi
Copy link
Contributor

changelog: none

Updates the description of unnecessary_join in accordance with #8579 (comment). I've also added a line regarding differences in assembly output, please let me know if it should also make it in.

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 6, 2022
@yoav-lavi
Copy link
Contributor Author

r? @flip1995

@rust-highfive rust-highfive assigned flip1995 and unassigned llogiq Apr 6, 2022
@flip1995
Copy link
Member

flip1995 commented Apr 6, 2022

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 6, 2022

📌 Commit 1ad6442 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Apr 6, 2022

⌛ Testing commit 1ad6442 with merge 30019d1...

@bors
Copy link
Contributor

bors commented Apr 6, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 30019d1 to master...

@bors bors merged commit 30019d1 into rust-lang:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants