Skip to content

Spellcheck #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Spellcheck #8705

merged 5 commits into from
Apr 15, 2022

Conversation

cpw2n5
Copy link

@cpw2n5 cpw2n5 commented Apr 15, 2022

I'm brand new to this so any feedback will be helpful. I set the project up locally and ran a spellcheck on it. The code changes should only be spelling corrections. I ran the build and tests and they came back successful locally.

changelog: Various spelling corrections in comments and code.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 15, 2022
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Manishearth
Copy link
Member

Manishearth commented Apr 15, 2022

There's a merge conflict, but I can approve this once you've fixed it (please prefer rebase, happy to do it for you if you need help)

@cpw2n5
Copy link
Author

cpw2n5 commented Apr 15, 2022

If you don't mind please rebase for me, I trust you more. Is there a way to avoid that in the future?

@Manishearth
Copy link
Member

Done, in general you can avoid it by ensuring you're working off an up-to-date branch, but sometimes stuff just changes while you're working on stuff and it's inevitable

@bors r+

@bors
Copy link
Contributor

bors commented Apr 15, 2022

📌 Commit e475dde has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Apr 15, 2022

⌛ Testing commit e475dde with merge 9938daf...

@bors
Copy link
Contributor

bors commented Apr 15, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 9938daf to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants