-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Spellcheck #8705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spellcheck #8705
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There's a merge conflict, but I can approve this once you've fixed it (please prefer rebase, happy to do it for you if you need help) |
If you don't mind please rebase for me, I trust you more. Is there a way to avoid that in the future? |
Done, in general you can avoid it by ensuring you're working off an up-to-date branch, but sometimes stuff just changes while you're working on stuff and it's inevitable @bors r+ |
📌 Commit e475dde has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
I'm brand new to this so any feedback will be helpful. I set the project up locally and ran a spellcheck on it. The code changes should only be spelling corrections. I ran the build and tests and they came back successful locally.
changelog: Various spelling corrections in comments and code.