-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Test metadata collection in Bors CI workflow #8988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e7197c
to
73396cc
Compare
@bors try |
[WIP] Test metadata collection in Bors CI workflow This PR adds a new check to bors CI workflows, which ensures that the metadata collection success, when it's run as part of the `deploy` script. I've only added it to bors workflows, as the runtime will be high while it'll also succeed most of the time. This is a preparation for #8947. --- changelog: none r? `@ghost`
💔 Test failed - checks-action_test |
73396cc
to
c6d04ec
Compare
@bors try |
[WIP] Test metadata collection in Bors CI workflow This PR adds a new check to bors CI workflows, which ensures that the metadata collection success, when it's run as part of the `deploy` script. I've only added it to bors workflows, as the runtime will be high while it'll also succeed most of the time. This is a preparation for #8947. --- changelog: none r? `@ghost`
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
r? @flip1995 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't increase the net CI time and we test a bit more. And we can track the perf of collect-metadata.
I don't see any downsides of adding this 👍
@bors r+ |
📌 Commit c6d04ec has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This PR adds a new check to bors CI workflows, which ensures that the metadata collection success, when it's run as part of the
deploy
script. I've only added it to bors workflows, as the runtime will be high while it'll also succeed most of the time. This is a preparation for #8947.changelog: none
r? @ghost