Skip to content

Test metadata collection in Bors CI workflow #8988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

xFrednet
Copy link
Member

This PR adds a new check to bors CI workflows, which ensures that the metadata collection success, when it's run as part of the deploy script. I've only added it to bors workflows, as the runtime will be high while it'll also succeed most of the time. This is a preparation for #8947.


changelog: none

r? @ghost

@xFrednet xFrednet force-pushed the 8947-test-monster-in-bors-ci branch from 6e7197c to 73396cc Compare June 12, 2022 13:57
@xFrednet
Copy link
Member Author

@bors try

bors added a commit that referenced this pull request Jun 12, 2022
[WIP] Test metadata collection in Bors CI workflow

This PR adds a new check to bors CI workflows, which ensures that the metadata collection success, when it's run as part of the `deploy` script. I've only added it to bors workflows, as the runtime will be high while it'll also succeed most of the time. This is a preparation for #8947.

---

changelog: none

r? `@ghost`
@bors
Copy link
Contributor

bors commented Jun 12, 2022

⌛ Trying commit 73396cc with merge c36a508...

@bors
Copy link
Contributor

bors commented Jun 12, 2022

💔 Test failed - checks-action_test

@xFrednet xFrednet force-pushed the 8947-test-monster-in-bors-ci branch from 73396cc to c6d04ec Compare June 12, 2022 14:22
@xFrednet
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jun 12, 2022

⌛ Trying commit c6d04ec with merge 24c8633...

bors added a commit that referenced this pull request Jun 12, 2022
[WIP] Test metadata collection in Bors CI workflow

This PR adds a new check to bors CI workflows, which ensures that the metadata collection success, when it's run as part of the `deploy` script. I've only added it to bors workflows, as the runtime will be high while it'll also succeed most of the time. This is a preparation for #8947.

---

changelog: none

r? `@ghost`
@bors
Copy link
Contributor

bors commented Jun 12, 2022

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 24c8633 (24c86330923a542bb9c798c6a8a9c72ce33e96ec)

@xFrednet
Copy link
Member Author

r? @flip1995

@xFrednet xFrednet changed the title [WIP] Test metadata collection in Bors CI workflow Test metadata collection in Bors CI workflow Jun 12, 2022
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't increase the net CI time and we test a bit more. And we can track the perf of collect-metadata.

I don't see any downsides of adding this 👍

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 13, 2022

📌 Commit c6d04ec has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jun 13, 2022

⌛ Testing commit c6d04ec with merge 17b7ab0...

@bors
Copy link
Contributor

bors commented Jun 13, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 17b7ab0 to master...

@bors bors merged commit 17b7ab0 into rust-lang:master Jun 13, 2022
@xFrednet xFrednet deleted the 8947-test-monster-in-bors-ci branch June 13, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants