[box_collection]: raise warn for all std collections
#9170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, only [Vec, String, Hashmap] were considered. Extend collection checklist for this lint with: - HashSet - VecDeque - LinkedList - BTreeMap - BTreeSet - BinaryHeap
|
r? @Jarcho (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Rqnsom
commented
Jul 13, 2022
| fn test1(foo: Box<Vec<bool>>) {} | ||
|
|
||
| fn test2(foo: Box<dyn Fn(Vec<u32>)>) { | ||
| // pass if #31 is fixed |
There was a problem hiding this comment.
// pass if #31 is fixed
Not sure what this means here. Is it referring to issue #31?
Because test2 is passing, so maybe comment is now obsolete?
There was a problem hiding this comment.
That looks like the reason.
There was a problem hiding this comment.
Maybe we can remove that comment within some future commit.
|
Thank you. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, only [
Vec,String,HashMap] were considered.Extend collection checklist for this lint with:
HashSetVecDequeLinkedListBTreeMapBTreeSetBinaryHeapchangelog: [
box_collection]: raise warn for all std collections