Use check_proc_macro for missing_const_for_fn
#9308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
daxpedda
commented
Aug 9, 2022
daxpedda
commented
Aug 9, 2022
clippy_utils/src/check_proc_macro.rs
Outdated
Comment on lines
267
to
271
| if visibility.is_public() { | ||
| (Pat::Str("pub"), end_pat) | ||
| } else { | ||
| (start_pat, end_pat) | ||
| } |
There was a problem hiding this comment.
Not entirely sure what is needed to be done here, do I have to cover more visibility kinds?
daxpedda
force-pushed
the
missing-const-for-fn
branch
from
fc5e699 to
8d4f2ac
Compare
|
r? @Jarcho |
daxpedda
force-pushed
the
missing-const-for-fn
branch
from
21e0ea9 to
6f5d648
Compare
Jarcho
reviewed
Aug 9, 2022
|
Thank you. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses @Jarcho's #8694 implementation to fix
missing_const_for_fnlinting in proc-macros.I'm not 100% sure what I'm doing here, any feedback is appreciated.
Previously: Jarcho#1.
Fixes #8854.
changelog: [
missing_const_for_fn]: No longer lints in proc-macros