Skip to content

new multi_assignment lint #9379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged

new multi_assignment lint #9379

merged 1 commit into from
Aug 26, 2022

Conversation

roynrishingha
Copy link
Contributor

@roynrishingha roynrishingha commented Aug 26, 2022

This fixes #6576

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

  • Followed [lint naming conventions][lint_naming]
  • Added passing UI tests (including committed .stderr file)
  • cargo test passes locally
  • Executed cargo dev update_lints
  • Added lint documentation
  • Run cargo dev fmt

changelog: add [multi_assignments] lint

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 26, 2022
@roynrishingha
Copy link
Contributor Author

roynrishingha commented Aug 26, 2022

r?@llogiq

@llogiq
Copy link
Contributor

llogiq commented Aug 26, 2022

Thank you for making clippy better! I have left suggestions to fix the failing test. Otherwise this looks good to merge. 👍

@roynrishingha
Copy link
Contributor Author

@llogiq all tests passed now!

@llogiq
Copy link
Contributor

llogiq commented Aug 26, 2022

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2022

📌 Commit fb7dffe has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 26, 2022

⌛ Testing commit fb7dffe with merge 21f103a...

@bors
Copy link
Contributor

bors commented Aug 26, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 21f103a to master...

@bors bors merged commit 21f103a into rust-lang:master Aug 26, 2022
@llogiq llogiq changed the title new lint new multi_assignment lint Aug 26, 2022
@roynrishingha roynrishingha deleted the multi_assignments branch April 20, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new lint for an assignment statement a = b = c
4 participants