Skip to content

[arithmetic-side-effects] Do not ignore literal references #9587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Oct 3, 2022

To my utter surprise, rustc does does not warn stuff like let n: u8 = &255 + &1 or let n: u8 = 255 + &1.

changelog: [arithmetic-side-effects] Do not ignore literal references

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 3, 2022
@Alexendoo
Copy link
Member

Thanks again!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 4, 2022

📌 Commit a44914f has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 4, 2022

⌛ Testing commit a44914f with merge 425e1ea...

@bors
Copy link
Contributor

bors commented Oct 4, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 425e1ea to master...

@bors bors merged commit 425e1ea into rust-lang:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants