Clippy Book Updates: Add write_tests chapter
#9668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
blyxyas
reviewed
Apr 2, 2023
| @@ -12,6 +12,8 @@ | |||
| - [Development](development/README.md) | |||
| - [Basics](development/basics.md) | |||
| - [Adding Lints](development/adding_lints.md) | |||
| - [Define Lints](development/define_lints.md) | |||
There was a problem hiding this comment.
A define_lints.md file is created with no contents, maybe a leftover from other PRs?
| detect `foo` functions and emit a lint. | ||
|
|
||
| As we gradually implement our lint logic, we will keep running and improving UI tests | ||
| untilthe output turns into what we want it to be. |
There was a problem hiding this comment.
A typo.
Suggested change
| untilthe output turns into what we want it to be. | |
| until the output turns into what we want it to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Issue #9311 and PR #9426.
Should depend on #9659 but only optional.
This chapter is related to defining new lints. Once approved, we'll rebase it on
masterwhich hasdefine_lintschapter.changelog: Docs: Updated development documentation, a new section for writing tests was added.
#9668
r? @flip1995