make ignored internally mutable types for mutable-key configurable
#9692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Alexendoo
reviewed
Oct 23, 2022
llogiq
force-pushed
the
mutable-key-more-arcs
branch
from
1bd11c1 to
6c89098
Compare
|
Thanks @Alexendoo for the review. I incorporated your suggestions. |
llogiq
force-pushed
the
mutable-key-more-arcs
branch
from
6c89098 to
d06539f
Compare
Alexendoo
reviewed
Oct 23, 2022
llogiq
force-pushed
the
mutable-key-more-arcs
branch
2 times, most recently
from
4939139 to
e5ebb02
Compare
Alexendoo
reviewed
Oct 24, 2022
llogiq
force-pushed
the
mutable-key-more-arcs
branch
from
e5ebb02 to
ab02459
Compare
We had some false positives where people would create their own types that had interior mutability unrelated to hash/eq. This addition lets you configure this as e.g. `arc-like-types=["bytes::Bytes"]`
llogiq
force-pushed
the
mutable-key-more-arcs
branch
from
ab02459 to
eba36e6
Compare
llogiq
changed the title
mutable-key configurablemutable-key configurable
Alexendoo
approved these changes
Oct 25, 2022
|
Nice, thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some false positives where people would create their own types that had interior mutability unrelated to hash/eq. This addition lets you configure this as e.g.
arc-like-types=["bytes::Bytes"]This fixes #5325 by allowing users to specify the types whose innards like
Arcshould be ignored (the generic types are still checked) for the sake of detecting inner mutability.r? @Alexendoo
changelog: Allow configuring types to ignore internal mutability in
mutable-key