Skip to content

Remove semicolon from the fn snippet #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

Kerollmops
Copy link

This allow users to compile an unimplemented function that don't return unit without having to edit this snippet.

@Kerollmops Kerollmops changed the title Remove semicolon form the fn snippet Remove semicolon from the fn snippet Apr 2, 2018
@Kerollmops
Copy link
Author

I did not understand the CI error, could you help me ? It seems to be related to an unstable feature.

@ehuss
Copy link

ehuss commented Apr 10, 2018

It's unrelated, you can ignore it. Nightly rust added some extra text to every error message. #267 contains a fix.

@jasonwilliams
Copy link
Member

retry

@jasonwilliams
Copy link
Member

@Kerollmops could you rebase and try again?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Kerollmops
Copy link
Author

done

@Kerollmops
Copy link
Author

ping @jasonwilliams

@jasonwilliams
Copy link
Member

@Kerollmops thanks for the PR! Will take a look when I’m back

@jasonwilliams jasonwilliams merged commit c16825d into rust-lang:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants