Skip to content

Fix "in this macro invocation" for desugarings. #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix "in this macro invocation" for desugarings. #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rust/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,9 +1065,13 @@ def find_span_r(span, expansion=None):

# Add a message for macro invocation site if available in the local
# crate.
#
# `macro_decl_name` can be a variety of things, like fn-like macro,
# attribute, derive, "desugaring of", etc. We can generally only
# handle macro_rules macros.
if span['expansion'] and \
not _is_external(window, span['file_name']) and \
not span['expansion']['macro_decl_name'].startswith('#['):
span['expansion']['macro_decl_name'].endswith('!'):
invoke_span, expansion = find_span_r(span)
# TODO: rustc now emits this in its text output in some cases.
# Consider trying to avoid the duplicate note.
Expand Down