Update all dependencies #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty heavy dependency, which is only used to check for the arguments "supports renderer". This doesn't actually drop the clap dependency from the tree due to mdbook. Hopefully I will get that fixed one day.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Mark-Simulacrum
approved these changes
Nov 12, 2023
|
Yea, I noted that in the commit message. Hopefully it can be fully removed in the future. There are a few reasons for removing it in blacksmith. One is that updating mdbook updated from clap 3 to 4, so it would need to be updated in blacksmith, too. However, the API changed, and I didn't want to try to figure out how to rewrite the code. I do hope someday to get the mdbook preprocessor into a separate crate to drop the dependency. This may motivate me to actually work on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all dependencies, including the version of mdbook used to build the site.
I dropped the use of
clapsince it was not really serving much purpose.