Skip to content

Provide custom messages for common errors #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varkor opened this issue Apr 9, 2018 · 0 comments
Open

Provide custom messages for common errors #11

varkor opened this issue Apr 9, 2018 · 0 comments

Comments

@varkor
Copy link
Member

varkor commented Apr 9, 2018

Some errors are extremely common in Rust pull requests, for example: not passing the tidy check. In these cases, the workflow could be simplified even more, by displaying a comment at the top of the bot's message (accompanying the usual output), for example:

Run ./x.py test tidy to identify rustc style errors.
Your code fails the tidy check on the following lines:
[...]

This may be going over the top, reducing the single click to open the spoiler box; feel free to close if it's not worth the effort! It does let reviewers more quickly scan to see what the problem is, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant