Maintenance #1170
Merged
Maintenance #1170
+1,854
−1,593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalgebra released version 0.34 with a bunch of optional dependencies that are not enabled by default[1]. The previous code didn't account for non-selected optional dependencies, so it was pulling in all of those versions. This rework was required in order to get access to Cargo's "feature resolver", which is the part we need to query to see if a dependency is active or not. Unfortunately, this required that we have a workspace and thus physical files on disk, which means that the overall implementation is much less elegant. [1]: https://crates.io/crates/nalgebra/0.34.0/dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.