Add span tracking to allow emitting diagnostics everywhere #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just tracking line numbers manually, this makes sure that everything preserves spans.
This is done by replicating most of the
str
API onSpanned<&str>
, so that you can just usetrim
,to_string
,chars
... and keep span information at all times. I was not able to measure a performance impact onjust check
.More can be done here, but I wanted to get a vibeck first before putting in more work.
Many situations already produce errors like
where before they did not have file, line and col information